Hash checks of parameter files during initialization #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
approved these changes
Aug 2, 2018
daira
approved these changes
Aug 2, 2018
src/rustzcash.rs
Outdated
| @@ -6,6 +6,12 @@ extern crate pairing; | |||
| extern crate rand; | |||
| extern crate sapling_crypto; | |||
|
|
|||
| const SPROUT_GROTH16_PARAMS_HASH: &'static str = "7a6723311162cb0c664c742d2fa42278195ade98ba3f21ef4fa02b82c83aed696e107e389ac7b3b0f33f417aeefe5be775d117910a473a422b4a1b97489fbdd6"; | |||
| const SAPLING_SPEND_PARAMS_HASH: &'static str = "35f6afd7d7514531aaa9fa529bdcddf116865f02abdd42164322bb1949227d82bdae295cad9c7b98d4bbbb00e045fa17aca79c90f53433a66bce4e82b6a1936d"; | |||
| const SAPLING_OUTPUT_PARAMS_HASH: &'static str = "f9d0b98ea51830c4974878f1b32bb68b2bf530e2e0ae09cd2a9b609d6fda37f1a1928e2d1ca91c31835c75dcc16057db53a807cc5cb37ebcfb753aa843a8ac21"; | |||
There was a problem hiding this comment.
These are not the hashes I have, after just doing zcutil/fetch-params.sh --testnet.
There was a problem hiding this comment.
I have the ones that @ebfull posted here: https://chat.zcashcommunity.com/channel/zcashd-team?msg=gKNBrseZN5wR9uFFk
There was a problem hiding this comment.
These are BLAKE2b hashes (as opposed to the SHA256 hashes used in fetch-params.) I didn't want to bring in another Rust dependency this late in the game.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Aug 3, 2018
Check the hash of the zk-SNARK parameters during initialization **Please also review zcash/librustzcash#28
|
Post-hoc re-utACK (now that I'm awake 😂) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.