Sanity check signs of raw number before comparison #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance issue when comparing large numbers to zero (or large positive numbers to large negative numbers). Without this check, the numbers are both converted to text, and string compared, which is costly if the numbers are large.
This patch provides a cheap early-exit option if the signs don't match, speeding up the cost of comparison to zero. As part of this, the .Modulo function calling .RawEquals here should also have significantly improved performance (which was otherwise an expensive check for large numbers).