Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned
GoString()
for acty.ObjectWithOptionalAttrs
was a bit off;the returned slice of optional attributes was twice as long as it needed
to be due to a mismatch where the slice was created with make, but then
appended to (as opposed to indexed into).
I didn't see test coverage for
Type
GoString()
, so I copied the test cases from Value'sGoString()
(fewer test cases, since I didn't need to differentiate between null and empty values). Here's the related test before the fix: