Resolve Dialyzer warnings #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typespec specifide the function as returning [...], which means a non-empty list. Since it's possible for the AST to not include any of the specified functions, this should be a possibly empty Keyword list instead.
File.write!/3 can only return :ok, so the second clause was redundant.
…error_msg/0 All of the possible return values for :os.type/0 are already explicitly covered
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was three warnings from Dialyzer.
A redundant case clause when matching against
File.read!/3: https://github.com/zeam-vm/pelemay/compare/master...QuinnWilton:quinn/dialyzer?expand=1#diff-4972a9be985f9b913c07209d94d51a2388f542f91879b0f5983ddf8179b4a06bL36A redundant case clause when matching against
:os.type/0: https://github.com/zeam-vm/pelemay/compare/master...QuinnWilton:quinn/dialyzer?expand=1#diff-207e0d18a388a2190dea937d097735e2a0edc66008b2594f7d3bc798515790bfL416An incorrect return type: https://github.com/zeam-vm/pelemay/compare/master...QuinnWilton:quinn/dialyzer?expand=1#diff-d0637b531f44050d0caee09480539649b69f5bbfed921ce18867be1c5623b472L351