-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PureScript LSP/Highlighting support #6911
Add PureScript LSP/Highlighting support #6911
Conversation
container_dir: PathBuf, | ||
node: &dyn NodeRuntime, | ||
) -> Option<LanguageServerBinary> { | ||
(|| async move { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an async_maybe!
macro in our util
crate that can make this a bit nicer than having the IIFE.
Here's an example of it used in another LSP adapter:
zed/crates/zed/src/languages/gleam.rs
Line 104 in 5b9cc26
async_maybe!({ |
I'm seeing some weird output in the generated Namely, it seems we're pointing to the
It looks like the cause is that |
364eb27
to
9ebe798
Compare
Hi @maxdeviant! I solved the mentioned problems, including the removal of some code that wasn't essential for the functionality (it was merely a leftover from an existing implementation with Node that I used as a template). |
Looks good! Thanks for getting this added, @ivanmoreau! |
PureScript support has been recently added to Zed editor in zed-industries/zed#6911, updated the README accordingly
This PR adds basic support for the language using the
purescript-language-server
.Release Notes: