-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object files for C++ input files are placed right next to source files #1367
Comments
bbannier
added a commit
that referenced
this issue
Jan 31, 2023
We previously would derive the name of the object file to generate for a given C++ input file directly from the input filename by just replacing the extension. This caused us to generate object files directly next to C++ files added explicitly to the JIT job. Multiple jobs using the same C++ input file could then race on the object file. With this patch we make sure that object files are always generated with taking the JIT has into account. We also fix the location of object files to always be in a system temp directory. Closes #1367.
bbannier
added a commit
that referenced
this issue
Jan 31, 2023
We previously would derive the name of the object file to generate for a given C++ input file directly from the input filename by just replacing the extension. This caused us to generate object files directly next to C++ files added explicitly to the JIT job. Multiple jobs using the same C++ input file could then race on the object file. With this patch we make sure that object files are always generated with taking the JIT has into account. We also fix the location of object files to always be in a system temp directory. Closes #1367. (cherry picked from commit 580443e)
bbannier
added a commit
that referenced
this issue
Jan 31, 2023
We previously would derive the name of the object file to generate for a given C++ input file directly from the input filename by just replacing the extension. This caused us to generate object files directly next to C++ files added explicitly to the JIT job. Multiple jobs using the same C++ input file could then race on the object file. With this patch we make sure that object files are always generated with taking the JIT has into account. We also fix the location of object files to always be in a system temp directory. Closes #1367. (cherry picked from commit 580443e)
Also backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If one adds a C++ file to a JIT invocation, the temporary object file is placed right next to the source file (which likely resides in some version-controlled directory, not even a build dir). The name of the object file is not unique. If multiple JIT jobs use the C++ file this will lead to races on the output file where different jobs might remove each others temporary file.
The text was updated successfully, but these errors were encountered: