Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VROM address handling in sym_info.py #2292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cadmic
Copy link
Contributor

@cadmic cadmic commented Nov 11, 2024

Ever since mapfile_parser 2.7.0, sym_info.py always treats address as VRAM addresses instead of VROM addresses, even for very low numbers:

$ ./sym_info.py -v ntsc-1.0 0x1F20
0x1F20 is at 0x1F20 bytes inside 'Soundfont_0_Start' (VRAM: 0x00000000, VROM: 0x00D390, SIZE: 0x3AA0, build/ntsc-1.0/assets/audio/soundfonts/Soundfont_0.o)

This restores the previous logic where a number >= 0x01000000 is treated as a VRAM address and a number < 0x01000000 is treated as a VROM address.

@cadmic
Copy link
Contributor Author

cadmic commented Nov 12, 2024

@AngheloAlf could you take a look? Not sure if you had plans here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants