Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some serious performance improvements.
Running Benchmak.js
const sampleData = Array(100000).fill({ carModel: 'BMW', price: 15000, color: 'red', transmission: 'manual' });
)I get this:
So json2csv gets 4 times faster and goes from the slowest to the fastest library around the block.
The results are similar passing the
fields
options (all of the above just get equally faster), and in safari and edge. However, in chrome json2csv is still not doing too well I need to investigate why.I'm sure that there is more room for improvement and I still need to test with more advanced options. But this is a good first step.
As side effects:
\n
and\t
)fields
options and has an object with fields but none of which match the given options).