Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower casing field names #362

Closed
daledude opened this issue Jun 13, 2016 · 1 comment
Closed

Lower casing field names #362

daledude opened this issue Jun 13, 2016 · 1 comment

Comments

@daledude
Copy link

Looks like lower casing was forced in #51. Is it possible to have a cli arg to disable this? I have a number of systems that require the case be the same as in the schema. I could remap it in my code but that would mean maintaining a mapping and conversion.

Thanks for consideration.
@osheroff
Copy link
Collaborator

yeah, I think the ideal behavior is to try to preserve the case that the columns were created with, but always do case-insensitive comparisons on lookup and such.

osheroff pushed a commit that referenced this issue Jul 13, 2016
Merge pull request #377 from zendesk/gh_362
d1e8b45 
#362: preserve case of columns as they came in
osheroff pushed a commit that referenced this issue Jul 14, 2016
v1.1.3, "the button I push to not have to go out"
c19df87 
This is a bugfix release, which fixes:
- #376, a problem parsing
  RENAME INDEX
- #371, a problem with the
  SERIAL datatype
- #362, we now preserve the
  original casing of columns
- #373, we were incorrectly
  expecting heartbeats to work under 5.1
osheroff pushed a commit that referenced this issue Jul 14, 2016
v1.1.3, "the button I push to not have to go out"
4ede35a 
This is a bugfix release, which fixes:
- #376, a problem parsing
  RENAME INDEX
- #371, a problem with the
  SERIAL datatype
- #362, we now preserve the
  original casing of columns
- #373, we were incorrectly
  expecting heartbeats to work under 5.1
This was referenced Oct 20, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@osheroff @daledude