Support for zcli theme preview #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had to work around a few issues with the typescript setup while developing and it seems like I'm seeing the same ones in this failed build. I wasn't sure if this should be something I should address in this PR as it's related to apps. Any guidance there would be very much appreciated 🙏🏼 |
Fredx87
reviewed
Apr 19, 2023
anpa
approved these changes
Apr 21, 2023
luis-almeida
force-pushed
the
luis.theme_preview
branch
9 times, most recently
from
aad7f59
to
e51a3cc
Compare
luis-almeida
force-pushed
the
luis.theme_preview
branch
from
e51a3cc
to
250c45f
Compare
luis-almeida
force-pushed
the
luis.theme_preview
branch
from
aa650a8
to
1757751
Compare
luis-almeida
force-pushed
the
luis.theme_preview
branch
from
1757751
to
8e46ece
Compare
|
I can't review this, but wanted to just put a comment in to say, AMAZING! Thank you all 🎉 |
luis-almeida
force-pushed
the
luis.theme_preview
branch
2 times, most recently
from
fe31076
to
acd8940
Compare
luis-almeida
force-pushed
the
luis.theme_preview
branch
from
acd8940
to
8499859
Compare
luis-almeida
force-pushed
the
luis.theme_preview
branch
from
2f8351e
to
ec0afa4
Compare
sarmadsangi
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
918bff3feat: adding support for zcli:theme previewb392bcadoc: documenting zcli:theme previewf73a3adAddressing PR feedback2a22bf8Address 'Unable to compile TypeScript' error338bba8Address 'type:check' failure7b01916Do not start preview if validation fails2c73f21Covering theme:preview with functional tests8a2cd40Replace fs.watch with chokidar to fix Ubunto builde4b3d9cMonitoring changes in the assets and settings folders as well23401ebRename zcli:theme command to zcli:themes9f3c5f9Implements basic livereload8e46eceFix typos8499859Use zcli login instead of custom logic2f1b78dImprove loggingec0afa4Add X-Zendesk-Request-Originator headercd6e974Adding a CODEOWNERS fileDetail
This PR adds support for
zcli theme:previewand hopefully provides an easy migration from ZAT.This ZAT being in maintenance mode, this migration is long overdue.
We plan to add other commands, e.g.
validateorpublishin the near future but we're starting withpreviewto ease the review of an already quite long PR.Checklist