Add a allowOrigin option to bypass invalid origins #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
In Guide (Help Center) we have successfully built a POC for an enduser app using
zaf
,zaf_sdk
andzcli
. We are now doing a final push to release this app in an EAP.As we talked about in one of our last meetings, Help Center supports host-mapped domains and this is currently leading to
Invalid domain [origin]
error screens. In this PR we're following your recommendation to introduce a way to bypass this check.We understand this allow list was added in #58 to address a security vulnerability so I'm thinking that, even thought left undocumented, this solution might reopen that vulnerability.
We'd really appreciate your feedback here 🙏🏼
Alternatively, help us think of another way to have this available only in Help Center.
Tasks
References
DevQA Steps
NOTE: DevQA steps are to be actioned only once code has been reviewed and approved.
Risks
Rollback Plan