-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LAB] ES6-ify #5
Conversation
@@ -1,22 +1,22 @@ | |||
var version = require('version'), | |||
Promise = require('../vendor/ayepromise'), | |||
var _Promise = require('../vendor/ayepromise'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the problem with es6/Babel Promise
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was 10 times the size and bigger than the SDK itself :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it worked? Meh, Promise
has pretty wide support, except for IE, it's a shame we can't use it and rely on browser availability 😿 Babel can transpile and optionally exclude certain features (if they're already available in target browsers), right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it worked :)
@danielbreves This looks cool! I stopped commenting on a few instances of |
is it possible to add a test case that the compiled artifact doesn't contain stuff that browsers don't support? |
Testing whether babel works? All of our target browser versions have ES5 support, right? |
ie9 and higher is es5, so yes. |
Testing that we've configured babel correctly. I know people who have accidentally deployed ES6 to the web because the pipeline wasn't babelify a particular file, with bad results for IE9 users. |
Closing in favour of #75 |
🐨
/cc @zendesk/quokka
Risks