Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect IP regex #246

Closed
wants to merge 1 commit into from
Closed

Fix incorrect IP regex #246

wants to merge 1 commit into from

Conversation

romankosiuh
Copy link

Fixes incorrect IP regex causing error when running zat validate:

zendesk/zendesk_apps_tools#313

$ zat package
/Library/Ruby/Gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2/ipv4.rb:71:in `initialize': Invalid IP "128.664.299.002" (ArgumentError)
        from /Library/Ruby/Gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2.rb:55:in `new'
        from /Library/Ruby/Gems/2.3.0/gems/ipaddress_2-0.13.0/lib/ipaddress_2.rb:55:in `parse'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:55:in `blocked_ip_type'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:41:in `block in blocked_ips_validation'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:40:in `each'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:40:in `each_with_object'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:40:in `blocked_ips_validation'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:30:in `block in call'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:16:in `each'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/validations/requests.rb:16:in `call'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_support-4.21.1/lib/zendesk_apps_support/package.rb:40:in `validate'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_tools-3.2.1/lib/zendesk_apps_tools/command.rb:92:in `validate'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_tools-3.2.1/lib/zendesk_apps_tools/command.rb:121:in `package'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
        from /Library/Ruby/Gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
        from /Library/Ruby/Gems/2.3.0/gems/zendesk_apps_tools-3.2.1/bin/zat:13:in `<top (required)>'
        from /usr/local/bin/zat:22:in `load'
        from /usr/local/bin/zat:22:in `<main>'
$ ruby -v
ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin18]

@romankosiuh romankosiuh closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants