[VEG-1298] Add bundler-audit and bundler-audit-fix #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tools for auditing vulnerabilities for ZAT. This is important in order to make sure that we ship secure code. As part of this change I needed to bump the major version of Thor, which is a gem used to handle the command line functionality for ZAT. When running bundler-audit-fix one can run `bundle exec bundler-audit-fix update .` [1] This should address vulnerabilities identified by `bundler-audit`. [1]: https://github.com/nobuyo/bundler-audit-fix
cl8au
reviewed
May 18, 2022
| @@ -15,7 +15,7 @@ Gem::Specification.new do |s| | |||
| s.required_ruby_version = '>= 2.3' | |||
| s.required_rubygems_version = '>= 1.3.6' | |||
|
|
|||
| s.add_runtime_dependency 'thor', '~> 0.19.4' | |||
| s.add_runtime_dependency 'thor', '~> 1.2.1' | |||
There was a problem hiding this comment.
this is a major version change which I guess require us to test it before release it out :)
cl8au
approved these changes
May 18, 2022
token-cjg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tools for auditing vulnerabilities for ZAT. This is important in
order to make sure that we ship secure code.
As part of this change I needed to bump the major version of Thor, which
is a gem used to handle the command line functionality for ZAT.
When running bundler-audit-fix one can run
bundle exec bundler-audit-fix update .[1]This should address vulnerabilities identified by
bundler-audit.[1]: https://github.com/nobuyo/bundler-audit-fix✌️
/cc @zendesk/vegemite
Tasks
References
Risks
Medium. Might break the command line functionality of ZAT as Thor, the library which powers the CLI, has been bumped by a major version. This should be easy to check though -- if one builds the gem manually and run
./bin/zat version, then things should still work.