Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to Garden theming v9 #242

Merged
merged 15 commits into from
Oct 3, 2024
Merged

feat!: upgrade to Garden theming v9 #242

merged 15 commits into from
Oct 3, 2024

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Oct 2, 2024

  • BREAKING CHANGE?

Description

  • 💥 Utility colors now map to the new v9 color palette
    • Expanded to support light & dark modes. See theme colors for details.
    • No longer offers secondary color muted (i.e. royal-M400) variants
  • 🚀 Adds new opacity utilities that correspond to v9 theme opacity

Detail

  • The example is updated to demonstrate dark mode styling
  • A toggle for light/dark is added to the example that defaults to the system color scheme
  • Due to comprehensive browser support, the focus-visible polyfill is no longer recommended

@jzempel jzempel requested a review from a team as a code owner October 2, 2024 17:17
Copy link

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🔥

@@ -6,7 +6,7 @@
"lint": "markdownlint README.md && npm run lint --workspaces",
"prepare": "npm run build --workspaces",
"start": "npm start --workspace=example",
"tag": "[ `git rev-parse --abbrev-ref HEAD` = 'main' ] && standard-version --no-verify",
"tag": "[ `git rev-parse --abbrev-ref HEAD` = 'main' ] && commit-and-tag-version --no-verify --npmPublishHint 'true'",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

commit-and-tag-version is a fork of standard-version. Because of maintainer availability, standard-version was deprecated on 15th May 2022. The previous maintainer recommends release-please as an alternative for those who are using GitHub actions. This fork exists for those who can't switch to release-please, or who would like to continue using standard-version.

https://github.com/absolute-version/commit-and-tag-version?tab=readme-ov-file#commit-and-tag-version

💯

@jzempel jzempel merged commit b54e338 into main Oct 3, 2024
3 checks passed
@jzempel jzempel deleted the jzempel/v9 branch October 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants