Move $padding argument to RsaOptions

[Moln]

Can I commit this?

$rsa = Zend\Crypt\PublicKey\Rsa::factory([
    'private_key' => $privateKey,
    'public_key' => $publicKey,
    'openssl_padding' => OPENSSL_PKCS1_PADDING
]);

$rsa->decrypt($rsa->encrypt('123456'));

//================================

$rsa = Zend\Crypt\PublicKey\Rsa::factory([
    'private_key' => $privateKey,
    'public_key' => $publicKey,
]);

$rsa->decrypt($rsa->encrypt('123456')); //Default padding == OPENSSL_PKCS1_OAEP_PADDING

[Ocramius]

Don't repeat the call chain to $this->getOptions()->getPadding(), as it is not guaranteed to return the same values over subsequent calls anyway. Assign it to a variable instead.

[Moln]

Sorry for my carelessness.

@Ocramius Thanks.

[Ocramius]

@Moln no need to be sorry, that's what the code reviews are for :-)