This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
New OpenSSL symmetric adapter + bcrypt refactor for PHP 5.5+ #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezimuel
changed the title
ezimuel
changed the title
|
@weierophinney this PR is ready to be merged in develop, thanks! |
| * Zend Framework (http://framework.zend.com/) | ||
| * | ||
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com) |
There was a problem hiding this comment.
@samsonasik Thanks, I updated the 2016 in all the code.
| 'padding' => 'pkcs7' | ||
| ]); | ||
| } catch (Symmetric\Exception\RuntimeException $e) { | ||
| $this->markTestSkipped($e->getMessage()); |
There was a problem hiding this comment.
Same note as for the mcrypt tests.
There was a problem hiding this comment.
@weierophinney even here, we are just testing if OpenSSL extension is enabled.
|
@ezimuel Looks very good! Just a few general notes:
I've added more specific notes elsewhere. Nice work! |
|
@weierophinney and @samsonasik I updated the PR will all your feedback, thanks! |
weierophinney
added a commit
that referenced
this pull request
May 5, 2016
New OpenSSL symmetric adapter + bcrypt refactor for PHP 5.5+
weierophinney
added a commit
that referenced
this pull request
May 5, 2016
weierophinney
added a commit
that referenced
this pull request
May 5, 2016
|
Merged to develop! We can tag 3.0 early next week, @ezimuel ! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the new OpenSSL symmetric adapter for zend-crypt ver. 3.0. We used this new adapter instead of Mcrypt in FileCipher and we suggested to use it in the documentation for all the other encryption needs. Mcrypt is an outdated extension and it will be deprecated) with PHP 7.1.
Moreover, this PR contains the
Zend\Crypt\Password\Bcryptrefactor using the password_hash() and password_verify() functions of PHP 5.5+.I updated the documentation according to these changes.
Note: All the changes included in this PR are backward compatible. I provided some unit tests as proof.