This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fix values for left and right outer join #26 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a BC break anyway because use constant instead value is not mandatory. You could do the following:
|
weierophinney
added
bug
enhancement
and removed
awaiting author updates
BC Break
labels
weierophinney
added a commit
that referenced
this pull request
Jul 22, 2015
weierophinney
added a commit
that referenced
this pull request
Jul 22, 2015
|
Merged to develop for release with 2.6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple replacement of the values according to #26.
Theses values have been there since e6ad682 and names have been changed in ecdf83e. Changing back to
JOIN_LEFT_OUTERandJOIN_RIGHT_OUTERwould have been meaningful but not done here because of the BC break it involves.