drop php 5.4 check and $that = $this usage #3
Conversation
| * | ||
| * @param string $columnA | ||
| * @param string $columnB | ||
| * | ||
| * @return int | ||
| */ | ||
| public function compareColumnOptions($columnA, $columnB) | ||
| private function compareColumnOptions($columnA, $columnB) |
There was a problem hiding this comment.
I would instead make this protected, however, this is a BC break in the event someone extended the class. You also cannot change visibility. I would revert this portion of the commit so that it can be merged to master and subsequently make this change against the develop branch as a secondary PR.
There was a problem hiding this comment.
The method had been marked as @internal and @private (I think by me). Can't have more warnings than that - private is perfectly fine here, and nobody should ever have relied on it in first place.
|
@Ocramius makes sense but still would need to be broken in a minor version vs. a bug fix release. |
|
should I change to protected, then? Warm regards, Abdul Malik Ikhsan Pada 23 Jul 2015, pukul 10.23, Mike Willbanks [email protected] menulis:
|
|
For me is not a BC break. |
|
This can be merged in next maintenance release |
No description provided.