This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Move EventFeature constants into separate interface #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the EventFeature event constants into a separate interface, removing the need to add a hard dependency on zend-eventmanager to the component. `EventFeature` now implements the interface, ensuring that references to the constants will continue to work, while `AbstractTableGateway` now uses the interface constants instead (ensuring that the zend-eventmanager dependency is not raised during usage).
- to prevent maintenance confusion later.
akrabat
added a commit
that referenced
this pull request
Sep 22, 2015
Move EventFeature constants into separate interface
akrabat
added a commit
that referenced
this pull request
Sep 22, 2015
akrabat
added a commit
that referenced
this pull request
Sep 22, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the EventFeature event constants into a separate interface, removing the need to add a hard dependency on zend-eventmanager to the component.
EventFeaturenow implements the interface, ensuring that references to the constants will continue to work, whileAbstractTableGatewaynow uses the interface constants instead (ensuring that the zend-eventmanager dependency is not raised during usage).Resolves #25 without requiring a new dependency.