This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Improvements for correct functioning of the Driver OCI8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class for count number of results
Changed for used to Feature RowCounter
Changed for used of Feature RowCounter
Ajusted call the createResult and add method clone
Ajusted problem with limit and offset in subselects
Ajusted for use quote of drive
Ajusted create plarform for oracle
Test for class RowCounter
Ajusted instance of array
Adjusted array format
Adjusted array format
unused_use and line_after_namespace
short_array_syntax
Added getDriver
function_declaration
Improved test coverage
method_argument_space, whitespacy_lines
Added tests
Improved test coverage
whitespacy_lines
Added tests
Improved test coverage
trailing_spaces
trailing_spaces
trailing_spaces
|
@ralphschindler care to take a look? |
| } | ||
|
|
There was a problem hiding this comment.
I'm pretty sure these are a result of running php-cs-fixer without specifying the configuration file. Unfortunately, php-cs-fixer, when run a second time with the configuration file, will not fix them. We can fix these on merge.
| /** | ||
| * @var bool | ||
| * @var null |
added file extension
Made adjustments mentioned by Maks3w
Made adjustments mentioned by Maks3w
Made adjustments mentioned by Maks3w
Made adjustments mentioned by Maks3w
Removed trailing_spaces
removed trailing_spaces
adjusted short_array_syntax, braces
weierophinney
added a commit
that referenced
this pull request
Jul 23, 2015
weierophinney
added a commit
that referenced
this pull request
Jul 23, 2015
|
We were in doubt regarding the comments and the bug label. We need to do more? |
|
@romulobusatto Note - all merged! :-) |
|
Ok, thanks! :D |
|
I found a problem on the initialize of result in Oci8. I need do a new pull request? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: zendframework/zendframework#7444