Add support for PHP 7.2

[thexpand]

No description provided.

[chris-kruining]

just a sec, I'll submit my fixes as a PR

[chris-kruining]

sorry, didn't notice this is a PR... whoops

[samsonasik]

php 7.1 and 7.2 need to be registered to .travis.yml

[thexpand]

@samsonasik Where can I take a look how it's done, so that I can complete this?

[samsonasik]

there is .travis.yml file which the php versions can be registered, for example https://github.com/zendframework/ZendDeveloperTools/blob/master/.travis.yml#L26-L35 , you can add php 7.1 and php 7.2 there after php 7

[michalbundyra]

There is no need to run cs-check on every PHP version - please remove it here and also on PHP 7.2.

[michalbundyra]

LGTM 👍

We just need update travis configuration/lock file, because it failing on PHP 5.6 and 7.2 locked.

[thexpand]

@webimpress Is there anything else I can do to help?

[michalbundyra]

@thexpand It would be nice if you can update the .travis.yml configuration. So basicaly we need define LEGACY_DEPS (see for example: https://github.com/zendframework/zend-servicemanager/blob/master/.travis.yml#L22) - I can't say what it should be in LEGACY_DEPS list in case of this repo - you need to figure it out based on current build logs.
Then we need update these legacy deps, as it is here:
https://github.com/zendframework/zend-servicemanager/blob/master/.travis.yml#L62-L63

Then we should be able to update composer.lock to the latest version (by running composer update) and all build should be fine.

[michalbundyra]

We can have also || ^7.1

[weierophinney]

Thanks, @thexpand. I have updated the Travis configuration, and also upped the minimum supported
version of PHPUnit so that it will work correctly with PHP 7.2; last tests passed all versions!

[thexpand]

@weierophinney Thanks for helping out. I was extremely busy lately and moreover I was not quite sure how to update the Travis file. Could you explain to me your changes?

[weierophinney]

@thexpand The approach is as follows:

• COMPOSER_ARGS only contains --no-interaction
• Individual locked environments add a LEGACY_DEPS env variable with specific dependencies that we know need different versions than are in the lock file.
• In the install target:
  • We do an initial composer install that also includes the --ignore-platform-reqs flag in order to install from the lock file.
  • We then check for a non-empty LEGACY_DEPS env variable, and, if found, run composer update --with-dependencies $LEGACY_DEPS; this installs the platform-specific versions of the dependencies listed, ensuring that there are no PHP version conflicts.
  • From there, we check for lowest/latest envs, and do composer updates accordingly
  • At the end, we cal stty cols 120 && composer show to list what dependencies were installed; the stty bit is to work around how composer shows the dependency table in non-TTY environments.

The only other change I made was to update PHPUnit to allow using versions 5.7+, 6, or 7 (and no longer use 4), as PHPUnit 4 and early 5.X series do not run under PHP 7.1 and up. This also meant some minor changes to the test suite.

[thexpand]

Detailed explanation as always 😉 Thank you once again, @weierophinney