Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Added PHP 7.3 support - updated Travis CI configuration #254

Closed
wants to merge 1 commit into from
Closed

Added PHP 7.3 support - updated Travis CI configuration #254

wants to merge 1 commit into from

Conversation

michalbundyra
Copy link
Member

With #253 it should work nice :)

@malukenho
Copy link
Member

It seems like the errors that we are having at first is on switch/continue/break! here you go a quick way to find files where it is broken $ find . -name '*.php' -exec php7.3 -l {} \;| grep -v '^No syntax errors'

@michalbundyra
Copy link
Member Author

@malukenho Please see #253, it is fixed there. Here we are just updating the Travis CI configuration.

weierophinney added a commit that referenced this pull request Mar 5, 2019
@weierophinney
docs: adds CHANGELOG entry for #253 and #254
86cfe77
weierophinney added a commit that referenced this pull request Mar 5, 2019
@weierophinney
Merge branch 'hotfix/php-7.3-support' into develop
88ab794 
Forward port #253
Forward port #254

Conflicts:
	CHANGELOG.md
@weierophinney
Copy link
Member

Cherry-picked to master and released with 1.2.2.

@michalbundyra michalbundyra deleted the feature/php-7.3-support branch March 5, 2019 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalbundyra @malukenho @weierophinney