This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Remove the global config array to ArrayObject conversion #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config array to object conversion is Aura.Di specific only. Other containers like Disco can't handle this. It's better to convert the config array only where needed. Aura.Di needs this since it's the only way to inject the config into the container as it only accepts objects.
geerteltink
added a commit
that referenced
this pull request
Nov 20, 2016
Remove the global config array to ArrayObject conversion
geerteltink
added a commit
that referenced
this pull request
Nov 20, 2016
|
Merged into develop for 1.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config array to object conversion is Aura.Di specific only. Other containers like disco (bitExpert/disco-demos#1) can't handle this. It's better to convert the config array only where needed.
Aura.Di needs this since it's the only way to inject the config into the container as it only accepts objects.
This PR moves the array to object conversion to the Aura.Di specific container.php file.
NOTE: This might be considered a BC break if the config is actually used as an object in 3rd party modules.