This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Push composer scripts into their own namespace #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mapped `Zend\Expressive\Composer` to `src/Composer/`. - Updated `pre-(install|update)-cmd` scripts to reference new namespace. - Updated namespace in `OptionalPackages` class. - Remove autoloading rules for installer script namespace as part of `composer.json` updates.
|
Good idea. Looks good. Personally, I don't like the namespace name of |
- per conversation with @akrabat
|
+1 from me. |
weierophinney
added a commit
that referenced
this pull request
Dec 9, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 9, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 9, 2015
|
I guess we can close #38 now :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a suggestion from @xtreamwayz, this patch moves the Composer installer script and assets to a separate namespace, via the following actions:
Zend\Expressive\Composerto the directorysrc/Composer/.pre-(install|update)-cmdscripts to reference the new namespace.OptionalPackagesclass.composer.jsonupdates.