This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Added installer option to remove composer.lock file from .gitignore file #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param IOInterface $io | ||
| * @return bool | ||
| */ | ||
| private static function requestExcludeComposerLock(IOInterface $io) |
There was a problem hiding this comment.
I don't think this needs to be a question. Best practice is to commit the lock file so it shouldn't be optional.
|
@weierophinney anything else you'd like to see in this pull request? |
| * @param string $content String to remove entry from. | ||
| * @return string | ||
| */ | ||
| public static function removeLine($entry, $content) |
There was a problem hiding this comment.
Let's rename this to removeLineFromFile().
There was a problem hiding this comment.
It did at first, but it didn't feel right since it isn't necessarily a file that is passed to it. But I can change it back.
There was a problem hiding this comment.
I missed that. Okay, let's change it to removeLineFromString(), then.
|
@jonsa I can make the suggested changes now, if you'd like; I'm working on some other updates for a 1.0.2 release today. |
|
@weierophinney That's fine by me. |
weierophinney
added a commit
that referenced
this pull request
Apr 21, 2016
…itignore Added installer option to remove composer.lock file from .gitignore file
weierophinney
added a commit
that referenced
this pull request
Apr 21, 2016
- Renames new method to `removeLineFromstring()` - Minor improvements to regex to ensure it only matches a line containing the given content (previous could match a partial line).
weierophinney
added a commit
that referenced
this pull request
Apr 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87