This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Mark package as a conflict with zend-servicemanager v2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in zendframework/zend-servicemanager#125, because this package duplicates several classes from zend-servicemanager v2, it is technically a conflict. This is noted in particular if you try do do `composer dumpautoload --optimize`, as that command will fail due to failure to disambiguate. As such, this patch removes the v2 compatibility within its requirements, and explicitly marks v2 as a conflict. Additionally, as this will be a breaking change, it also updates the package to specify PHP 5.6 as the new minimum supported PHP version.
|
Looks good. |
weierophinney
added a commit
that referenced
this pull request
Jun 13, 2016
weierophinney
added a commit
that referenced
this pull request
Jun 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in zendframework/zend-servicemanager#125, because this package duplicates several classes from zend-servicemanager v2, it is technically a conflict. This is noted in particular if you try do do
composer dumpautoload --optimize, as that command will fail due to failure to disambiguate.As such, this patch removes the v2 compatibility within its requirements, and explicitly marks v2 as a conflict.
Additionally, as this will be a breaking change, it also updates the package to specify PHP 5.6 as the new minimum supported PHP version.