This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
change withConfig() to configure() in migration doc #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,7 +100,7 @@ methods for injecting new services, such as: | |||
|
|
|||
| then you will need to alter the logic to instead aggregate a full configuration | |||
| specification. This can then be passed to the `ServiceManager` instance's | |||
| `withConfig()` method, which does the following: | |||
| `configure()` method, which does the following: | |||
|
|
|||
| - Creates a clone of the manager. | |||
There was a problem hiding this comment.
is return $this in configure() create a clone?
samsonasik
force-pushed
the
with-config-configure
branch
from
246a26b
to
daab247
Compare
|
rebased. should be merge-able now ;) |
weierophinney
added a commit
that referenced
this pull request
Jan 11, 2016
change withConfig() to configure() in migration doc
weierophinney
added a commit
that referenced
this pull request
Jan 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favor of #47