Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant Darglint checks #3067

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 9, 2024

Describe changes

I changed a few Darglint checks:

  • I removed it from Slow CI, since it is done in Fast already
  • Run it only for changed Python files and not for the whole population

Skipped run, since no changes: https://github.com/zenml-io/zenml/actions/runs/11252083121/job/31284460818
Has changes: https://github.com/zenml-io/zenml/actions/runs/11252118005/job/31284589339?pr=3067

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant