Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kaniko image builder service account passing #3081

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix Kaniko image builder service account passing #3081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec93642
Pass Kaniko service account correctly
schustmi Oct 14, 2024
7422832
Auto-update of LLM Finetuning template
actions-user Oct 14, 2024
353ed36
Auto-update of Starter template
actions-user Oct 14, 2024
74c7907
Auto-update of E2E template
actions-user Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/e2e/.copier-answers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Changes here will be overwritten by Copier
_commit: 2024.10.09-2-g429e445
_commit: 2024.10.10
_src_path: gh:zenml-io/template-e2e-batch
data_quality_checks: true
email: [email protected]
Expand Down
2 changes: 1 addition & 1 deletion examples/llm_finetuning/.copier-answers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Changes here will be overwritten by Copier
_commit: 2024.08.29-1-ge25e9e0
_commit: 2024.09.24
_src_path: gh:zenml-io/template-llm-finetuning
bf16: true
cuda_version: cuda11.8
Expand Down
2 changes: 1 addition & 1 deletion examples/mlops_starter/.copier-answers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Changes here will be overwritten by Copier
_commit: 2024.09.23-1-g9128c4b
_commit: 2024.09.24
_src_path: gh:zenml-io/template-starter
email: [email protected]
full_name: ZenML GmbH
Expand Down
6 changes: 3 additions & 3 deletions src/zenml/integrations/kaniko/image_builders/kaniko_image_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ def _generate_spec_overrides(
"--image-name-with-digest-file=/dev/termination-log",
] + self.config.executor_args

optional_container_args: Dict[str, Any] = {}
optional_spec_args: Dict[str, Any] = {}
if self.config.service_account_name:
optional_container_args["serviceAccountName"] = (
optional_spec_args["serviceAccountName"] = (
self.config.service_account_name
)

Expand All @@ -218,10 +218,10 @@ def _generate_spec_overrides(
"env": self.config.env,
"envFrom": self.config.env_from,
"volumeMounts": self.config.volume_mounts,
**optional_container_args,
}
],
"volumes": self.config.volumes,
**optional_spec_args,
},
}

Expand Down