Cleaner rerendering #177
Merged
Cleaner rerendering #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concept of `cleanProps` allows performing regular updates that affect DOM nodes. Keyed elements and controlled lifecycle avoid breaking Quill during re-renders. Optimized comparisons for value prop updates after content changes.
|
@alexkrolick try doing something outrageous, such as changing the theme every few seconds. Changing things like Focus can't be maintained (yet) when re-rendering the whole Quill. |
I'm thinking that these APIs should be used in the regeneration case: |
|
Demo of the two cases to confirm this is working: https://codepen.io/alexkrolick/pen/KWBJgQ?editors=0010 |
- preserves focus between dirty updates
|
@zenoamaro 🍾 Type something and wait for the theme to change: |
alexkrolick
approved these changes
Mar 26, 2017
- clear the cached selection and quill delta after regenerating for a dirty update so that later changes will pass through to the state.value condition - add comments for regeneration code
|
Great, thanks a lot! 🎩 |
|
I considered making this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concept of
cleanPropsallows performing regular updates that affect DOM nodes.Keyed elements and controlled lifecycle avoid breaking Quill when re-rendering.
Optimized comparisons for value prop updates after content changes.
Should fix #147 and others.