Feature/commonjs support #19
Conversation
These configs in package.json enables the dist file to be required in commonjs envs without babel.
This commit adds tests to make sure that the browserify bundle will work in the dist file of clipboard.js This commit adds the mocha and chai modules, since karma doesn't work well with node only tests. Also splited tests tasks in package.json and updated .gitignore
|
Could you try removing https://github.com/zenorocha/clipboard.js/blob/master/karma.conf.js#L23 from here and pass it in the command line? I guess that would prevent us from adding Mocha and Chai again. Also rename |
|
what you mean with "prevent from adding mocha and chai again"? You mean to remove from I think we need Or did I get something wrong? |
|
Ahhh, sorry man, I get it now, I can use karma to run the tests without using a browser. I'll work on it :) |
|
Just started reviewing :) |
Sent from 
|
Thank you, pull request merged! See changes here. |
|
PR merged! Sorry @mauriciosoares, I was wrong about Karma, it always needs a browser to run. I renamed the test file to Would be awesome to have you leading this interoperability effort :) |
|
Hey @zenorocha, I can't promise you I'll have enough time to do these guys fast... But as soon as I have a few, I'll try to take a look at some issues, and work on them. Thanks for the invite.
|
This PR adds support for node envs that uses browserify but does not uses babel as a transformer.
Updated tests, in this case I had to add Mocha and Chai for testing the node part, since karma was not built to test envs that are not browser based (correct me if I'm wrong). Don't know if this is the best approach, but was the simplest that I found.
This closes the issue #15