Fixed type hints for scalar arguments for PHP < 7.2

Refs: - #1658
zephir-lang · Nov 25, 2018 · 4c101c7 · 4c101c7
1 parent ca70d72
commit 4c101c7
Showing 1 changed file with 24 additions and 0 deletions.
diff --git a/Library/ArgInfoDefinition.php b/Library/ArgInfoDefinition.php
@@ -218,6 +218,7 @@ private function renderEnd()
 
                 case '1:bool':
                 case '1:boolean':
+                    $this->codePrinter->output('#if PHP_VERSION_ID >= 70200');
                     $this->codePrinter->output(
                         sprintf(
                             "\tZEND_ARG_TYPE_INFO(%d, %s, %s, %d)",
@@ -227,12 +228,18 @@ private function renderEnd()
                             (int) $this->allowNull($parameter)
                         )
                     );
+                    $this->codePrinter->output('#else');
+                    $this->codePrinter->output(
+                        sprintf("\tZEND_ARG_INFO(%d, %s)", $this->passByReference($parameter), $parameter['name'])
+                    );
+                    $this->codePrinter->output('#endif');
                     break;
                 case '1:uchar':
                 case '1:int':
                 case '1:uint':
                 case '1:long':
                 case '1:ulong':
+                    $this->codePrinter->output('#if PHP_VERSION_ID >= 70200');
                     $this->codePrinter->output(
                         sprintf(
                             "\tZEND_ARG_TYPE_INFO(%d, %s, IS_LONG, %d)",
@@ -241,8 +248,14 @@ private function renderEnd()
                             (int) $this->allowNull($parameter)
                         )
                     );
+                    $this->codePrinter->output('#else');
+                    $this->codePrinter->output(
+                        sprintf("\tZEND_ARG_INFO(%d, %s)", $this->passByReference($parameter), $parameter['name'])
+                    );
+                    $this->codePrinter->output('#endif');
                     break;
                 case '1:double':
+                    $this->codePrinter->output('#if PHP_VERSION_ID >= 70200');
                     $this->codePrinter->output(
                         sprintf(
                             "\tZEND_ARG_TYPE_INFO(%d, %s, IS_DOUBLE, %d)",
@@ -251,9 +264,15 @@ private function renderEnd()
                             (int) $this->allowNull($parameter)
                         )
                     );
+                    $this->codePrinter->output('#else');
+                    $this->codePrinter->output(
+                        sprintf("\tZEND_ARG_INFO(%d, %s)", $this->passByReference($parameter), $parameter['name'])
+                    );
+                    $this->codePrinter->output('#endif');
                     break;
                 case '1:char':
                 case '1:string':
+                    $this->codePrinter->output('#if PHP_VERSION_ID >= 70200');
                     $this->codePrinter->output(
                         sprintf(
                             "\tZEND_ARG_TYPE_INFO(%d, %s, IS_STRING, %d)",
@@ -262,6 +281,11 @@ private function renderEnd()
                             (int) $this->allowNull($parameter)
                         )
                     );
+                    $this->codePrinter->output('#else');
+                    $this->codePrinter->output(
+                        sprintf("\tZEND_ARG_INFO(%d, %s)", $this->passByReference($parameter), $parameter['name'])
+                    );
+                    $this->codePrinter->output('#endif');
                     break;
                 default:
                     $this->codePrinter->output(