Amended tests for #2057 (part III)

zephir-lang · Apr 23, 2020 · 8da899b · 8da899b
1 parent 4a0ecb6
commit 8da899b
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/unit-tests/Extension/Oo/Scopes/PrivateScopeTest.php b/unit-tests/Extension/Oo/Scopes/PrivateScopeTest.php
@@ -157,7 +157,6 @@ public function shouldSetPrivatePropertyNewInternal()
      */
     public function shouldNotSetPrivatePropertyViaThis()
     {
-        $this->markTestSkipped('This test is not ready');
         $this->expectException(Error::class);
         $this->expectExceptionMessage(
             'Cannot access private property TestScopeExtending::$privateProperty'
@@ -187,8 +186,10 @@ public function shouldSetPrivatePropertyViaThis()
      */
     public function shouldNotSetPrivatePropertyExtendedMagicObjInternal()
     {
-        $this->markTestSkipped('This test is not ready');
         $this->expectException(Error::class);
+        $this->expectExceptionMessage(
+            'Cannot access private property TestScopeExtendingMagic::$privateProperty2'
+        );
 
         $object = new TestScopeExtendingMagic();
         $tester = new PrivateScopeTester();
@@ -203,8 +204,10 @@ public function shouldNotSetPrivatePropertyExtendedMagicObjInternal()
      */
     public function shouldNotSetPrivatePropertyExtendedMagicNewInternal()
     {
-        $this->markTestSkipped('This test is not ready');
         $this->expectException(Error::class);
+        $this->expectExceptionMessage(
+            'Cannot access private property TestScopeExtendingMagic::$privateProperty2'
+        );
 
         $tester = new PrivateScopeTester();
         $tester->setPropertyNew(TestScopeExtendingMagic::class, 'privateProperty2', 'test');
@@ -217,8 +220,10 @@ public function shouldNotSetPrivatePropertyExtendedMagicNewInternal()
      */
     public function shouldNotSetPrivatePropertyExtendedMagicObjPhp()
     {
-        $this->markTestSkipped('This test is not ready');
         $this->expectException(Error::class);
+        $this->expectExceptionMessage(
+            'Cannot access private property TestScopePhpMagicExtending::$privateProperty2'
+        );
 
         $obj = new TestScopePhpMagicExtending();
 
@@ -233,8 +238,10 @@ public function shouldNotSetPrivatePropertyExtendedMagicObjPhp()
      */
     public function shouldNotSetPrivatePropertyExtendedMagicNewPhp()
     {
-        $this->markTestSkipped('This test is not ready');
         $this->expectException(Error::class);
+        $this->expectExceptionMessage(
+            'Cannot access private property TestScopePhpMagicExtending::$privateProperty2'
+        );
 
         $tester = new PrivateScopeTester();
         $tester->setPropertyNew(TestScopePhpMagicExtending::class, 'privateProperty2', 'test');