Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation error with inheritance of prototype interfaces #1770

Merged
merged 2 commits into from
Dec 1, 2018

Conversation

sergeyklay
Copy link
Contributor

Closes: #1758

@sergeyklay sergeyklay force-pushed the fix/inheritance-of-prototype-interfaces branch 2 times, most recently from 2db2746 to 4bf3bc7 Compare December 1, 2018 12:00
@sergeyklay sergeyklay force-pushed the fix/inheritance-of-prototype-interfaces branch from 4bf3bc7 to 06ffbfa Compare December 1, 2018 12:26
@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #1770 into development will increase coverage by 0.44%.
The diff coverage is 25.92%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1770      +/-   ##
=================================================
+ Coverage          42.68%   43.12%   +0.44%     
- Complexity          8018     8019       +1     
=================================================
  Files                528      528              
  Lines              42049    42081      +32     
=================================================
+ Hits               17949    18149     +200     
+ Misses             24100    23932     -168
Impacted Files Coverage Δ Complexity Δ
Library/CompilerFile.php 64.2% <ø> (+3.11%) 154 <0> (ø) ⬇️
Library/ClassDefinition.php 46.84% <19.04%> (+17.99%) 271 <0> (+1) ⬆️
Library/Compiler.php 61.48% <50%> (+0.97%) 293 <0> (ø) ⬇️
Library/Backends/ZendEngine3/Backend.php 18.45% <0%> (+0.45%) 192% <0%> (ø) ⬇️
Library/ClassMethod.php 50.16% <0%> (+0.64%) 371% <0%> (ø) ⬇️
Library/CodePrinter.php 54.16% <0%> (+1.38%) 23% <0%> (ø) ⬇️
Library/functions.php 43.95% <0%> (+2.19%) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeeebf5...06ffbfa. Read the comment docs.

@sergeyklay sergeyklay merged commit 2382e2f into development Dec 1, 2018
@sergeyklay sergeyklay deleted the fix/inheritance-of-prototype-interfaces branch December 1, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants