Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1400 #1819

Merged
merged 4 commits into from
Feb 22, 2019
Merged

Fix #1400 #1819

merged 4 commits into from
Feb 22, 2019

Conversation

dreamsxin
Copy link
Contributor

@dreamsxin dreamsxin commented Feb 21, 2019

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@sergeyklay
Copy link
Contributor

@dreamsxin This code seems to be incompatible with the Windows compiler. At least we have the following:

concat.c
C:\projects\zephir\ext\kernel\array.c(98): error C2059: syntax error: '}'
C:\projects\zephir\ext\kernel\array.c(166): error C2059: syntax error: '}'
C:\projects\zephir\ext\kernel\array.c(167): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(169): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(170): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(170): warning C4133: 'function': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(172): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(167): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(169): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(172): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(204): error C2059: syntax error: '}'
C:\projects\zephir\ext\kernel\array.c(205): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(207): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(209): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(205): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(207): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(209): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(245): error C2059: syntax error: '}'
C:\projects\zephir\ext\kernel\array.c(286): error C2059: syntax error: '}'
C:\projects\zephir\ext\kernel\array.c(287): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(289): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(290): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(290): warning C4133: 'function': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(287): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(289): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(307): error C2059: syntax error: '}'
C:\projects\zephir\ext\kernel\array.c(308): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(310): error C2065: 'offset': undeclared identifier
C:\projects\zephir\ext\kernel\array.c(308): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
C:\projects\zephir\ext\kernel\array.c(310): warning C4133: 'initializing': incompatible types - from 'int *' to 'zval *'
debug.c

I think this can be made more portable. Could you take a look?
https://ci.appveyor.com/project/sergeyklay/zephir/builds/22545498/job/eqfm2ltqtgtcex0c?fullLog=true#L61

@dreamsxin
Copy link
Contributor Author

dreamsxin commented Feb 22, 2019

PHP 5.x will be supported today.

@dreamsxin
Copy link
Contributor Author

@sergeyklay All right

Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sergeyklay sergeyklay merged commit ad604a2 into zephir-lang:development Feb 22, 2019
@sergeyklay
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants