Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local memory management #1880

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Use local memory management #1880

merged 2 commits into from
Jun 28, 2019

Conversation

dreamsxin
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@dreamsxin dreamsxin mentioned this pull request Jun 28, 2019
Closed
sergeyklay
sergeyklay approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dreamsxin dreamsxin changed the title [WIP]Use local memory management - DONT MERGE!! [WIP]Use local memory management Jun 28, 2019
@dreamsxin
Copy link
Contributor Author

@sergeyklay continuous-integration/appveyor/pr failed

@dreamsxin
Copy link
Contributor Author

Can help fix it and merge @sergeyklay

@sergeyklay
Copy link
Contributor

@dreamsxin

C:\projects\zephir\ext\kernel\memory.c(86): error C2373: 'zephir_memory_restore_stack': redefinition; different type modifiers
C:\projects\zephir\ext\kernel/memory.h(66): note: see declaration of 'zephir_memory_restore_stack'
operators.c
require.c
string.c
time.c

@dreamsxin dreamsxin merged commit 765f726 into zephir-lang:development Jun 28, 2019
@sergeyklay
Copy link
Contributor

Thank you!

@sergeyklay sergeyklay changed the title [WIP]Use local memory management Use local memory management Jul 18, 2019
dreamsxin added a commit to dreamsxin/zephir that referenced this pull request Nov 6, 2019
@dreamsxin
Use local memory management (zephir-lang#1880)
209709e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamsxin @sergeyklay