Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1965 #1971

Merged
merged 4 commits into from
Oct 13, 2019
Merged

Revert #1965 #1971

merged 4 commits into from
Oct 13, 2019

Conversation

sergeyklay
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Changes proposed in #1965 broke our tests
For more see:

Thanks

@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #1971 into development will increase coverage by 2.98%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##             development    #1971      +/-   ##
=================================================
+ Coverage          31.01%   33.99%   +2.98%     
  Complexity          8260     8260              
=================================================
  Files                561      561              
  Lines              46871    44948    -1923     
=================================================
+ Hits               14538    15282     +744     
+ Misses             32333    29666    -2667

@sergeyklay sergeyklay merged commit 823812a into development Oct 13, 2019
@sergeyklay sergeyklay deleted the fix/1965 branch October 13, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant