Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2020 #2037

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Fix #2020 #2037

merged 1 commit into from
Dec 31, 2019

Conversation

dreamsxin
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@codecov
Copy link

codecov bot commented Dec 31, 2019

Codecov Report

Merging #2037 into development will decrease coverage by 0.27%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##             development    #2037      +/-   ##
=================================================
- Coverage          35.63%   35.35%   -0.28%     
- Complexity          8218     8323     +105     
=================================================
  Files                562      564       +2     
  Lines              45340    45744     +404     
=================================================
+ Hits               16157    16175      +18     
- Misses             29183    29569     +386

Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergeyklay sergeyklay merged commit 9a96030 into zephir-lang:development Dec 31, 2019
@niden niden added the bug label Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants