[WIP] Test #2078 #2079
Closed
[WIP] Test #2078 #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used the same function to change properties of an object:
1. let object->property = expression
2. class A { private object = []; }
And to be able to change object's property we had to use object's scope.
Thus, we have NEVER checked the scope in which we are actually located:
// Global Scope
class Bar {
// Bar's Scope
private prop;
}
class Foo {
// Foo's Scope
public function test (Bar bar) {
// Here we replaced the scope by Bar's one
let bar->prop = 42;
}
}
Fixes zephir-lang#2057
/cc @niden @Jurigag
Codecov Report
@@ Coverage Diff @@
## development #2079 +/- ##
=================================================
+ Coverage 35.97% 36.02% +0.05%
+ Complexity 8306 8296 -10
=================================================
Files 565 566 +1
Lines 46122 46172 +50
=================================================
+ Hits 16593 16635 +42
- Misses 29529 29537 +8 |
|
Closed in favor of #2078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.