Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support dspi for s32z270dc2 #435

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Add support dspi for s32z270dc2 #435

merged 4 commits into from
Oct 18, 2024

Conversation

tunguyen4585
Copy link
Contributor

@tunguyen4585 tunguyen4585 commented Sep 12, 2024 •
edited
Loading

This PR to add support dspi for s32z27x devices
Tested on tests\drivers\spi\spi_loopback\drivers.spi.s32z_dspi.loopback
------ TESTSUITE SUMMARY START ------
SUITE PASS - 100.00% [spi_loopback]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.366 seconds
PASS - [spi_loopback.test_spi_loopback] duration = 0.366 seconds
------ TESTSUITE SUMMARY END ------

@zephyrbot zephyrbot mentioned this pull request Sep 12, 2024
Merged
@manuargue manuargue requested review from manuargue and Dat-NguyenDuy and removed request for manuargue September 12, 2024 09:36
@manuargue manuargue self-assigned this Sep 12, 2024
manuargue
manuargue suggested changes Sep 13, 2024
View reviewed changes
s32/mcux/devices/S32Z270/fsl_device_registers.h Outdated Show resolved Hide resolved
dts/nxp/s32/S32Z27-BGA594-pinctrl.h Outdated Show resolved Hide resolved
Dat-NguyenDuy
Dat-NguyenDuy suggested changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@Dat-NguyenDuy Dat-NguyenDuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @tunguyen4585, we need to patch mcux-sdk DSPI driver, blocking this PR until the patch is merged and picked up into this PR

@tunguyen4585
Copy link
Contributor Author

As discussed with @tunguyen4585, we need to patch mcux-sdk DSPI driver, blocking this PR until the patch is merged and picked up into this PR

The PR on mcux-sdk was merged, wait it sync to github

@manuargue manuargue changed the title Add support dspi for s32z 2.0.0 Add support dspi for s32z270dc2 Sep 23, 2024
@Dat-NguyenDuy
Copy link
Collaborator

As discussed with @tunguyen4585, we need to patch mcux-sdk DSPI driver, blocking this PR until the patch is merged and picked up into this PR

You'll need to update Patch List from README as well

@tunguyen4585
Copy link
Contributor Author

As discussed with @tunguyen4585, we need to patch mcux-sdk DSPI driver, blocking this PR until the patch is merged and picked up into this PR

You'll need to update Patch List from README as well

I updated

manuargue
manuargue suggested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@manuargue manuargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block until zephyr pr approved

@tunguyen4585 tunguyen4585 force-pushed the support-dspi-for-s32z-2.0.0 branch 2 times, most recently from 5926c99 to 8d06acb Compare September 26, 2024 04:14
@manuargue
Copy link
Member

@tunguyen4585 please rebase

@tunguyen4585
nxp: mcux: drivers: dspi: add the guards for unsupported features
7dbf694 
In order to re-use mcux DSPI driver for NXP s32z27x device, we need
to disable the following features which are not available on this
platform: SR[TFUF], RSER[TFUF_RE], SLAVE mode

Signed-off-by: Tu Nguyen Van <[email protected]>
@tunguyen4585
dts: nxp: s32: support more required pins for DSPI_10
252c707 
support more required pins for DSPI_10

Signed-off-by: Tu Nguyen Van <[email protected]>
@tunguyen4585
nxp: s32: drivers: s32ze: BaseNXP: header: remove S32Z2_SPI.h
471be00 
"Remove S32Z2_SPI.h as it will cause duplicate SPI_Type conflicts when
supporting DSPI using the MCUX driver."

This removal won't affect SPI shim driver because this header file is
already included inside the RTD SPI driver

Signed-off-by: Tu Nguyen Van <[email protected]>
@tunguyen4585
s32: mcux: s32z270: add support dspi over mcux drivers
0758ba1 
add support dspi over mcux drivers

Signed-off-by: Tu Nguyen Van <[email protected]>
@manuargue
Copy link
Member

zephyr pr approved by assignee, merging

@manuargue manuargue merged commit 683c007 into zephyrproject-rtos:master Oct 18, 2024
@manuargue manuargue deleted the support-dspi-for-s32z-2.0.0 branch October 18, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dat-NguyenDuy Dat-NguyenDuy Dat-NguyenDuy approved these changes

@dleach02 dleach02 dleach02 approved these changes

@manuargue manuargue manuargue approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

Assignees

@manuargue manuargue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tunguyen4585 @Dat-NguyenDuy @manuargue @dleach02