Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr: use k_cpu_idle instead of arch_cpu_idle #21

Conversation

dcpleung
Copy link
Member

@dcpleung dcpleung commented Nov 8, 2023

arch_cpu_idle() is an internal API that should not be used outside of the main Zephyr. Use k_cpu_idle() instead, which is the same thing (at least for now).

arch_cpu_idle() is an internal API that should not be used
outside of the main Zephyr. Use k_cpu_idle() instead, which
is the same thing (at least for now).

Signed-off-by: Daniel Leung <[email protected]>
@carlocaione
Copy link
Collaborator

@dcpleung can you open a PR on the main libmetal repo? https://github.com/OpenAMP/libmetal

@arnopo
Copy link
Collaborator

arnopo commented Nov 10, 2023

Hello @dcpleung

Please post you PR on the https://github.com/OpenAMP/libmetal as it is the original library
When integrated this module will have to be rebased.

@dcpleung
Copy link
Member Author

Here is the PR to the main libmetal repo: OpenAMP/libmetal#276.

@dcpleung
Copy link
Member Author

dcpleung commented Nov 20, 2023

The PR to the library repo has been merged. What would be the next step? Do we wait till the next release and then pull them in? Or do we merge it here for now so main Zephyr repo can use it?

@arnopo
Copy link
Collaborator

arnopo commented Nov 21, 2023

The PR to the library repo has been merged. What would be the next step? Do we wait till the next release and then pull them in? Or do we merge it here for now so main Zephyr repo can use it?

I created PR #22 to merge the release + rebase on top of your commit, please could you test it?

@dcpleung
Copy link
Member Author

I have updated zephyrproject-rtos/zephyr#64987 to use #22, and will let CI run through its course.

@arnopo
Copy link
Collaborator

arnopo commented Dec 15, 2023

The commit as been merged in 55aac79

@arnopo arnopo closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants