Bluetooth: Controller: Deprecate tinycrypt part2 (testing) #160491
cvinayakcompliance.yml
on: pull_request
Run compliance checks on patch series (PR)
2m 32s
Annotations
1 error, 1 warning, and 10 notices
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll,
- uint16_t latency, uint8_t bn,
- uint16_t handle,
- struct node_rx_pdu *node_rx);
+static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll, uint16_t latency,
+ uint8_t bn, uint16_t handle, struct node_rx_pdu *node_rx);
File:subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c
Line:63
You may want to run clang-format on this change:
- err = lll_prepare(is_abort_cb, abort_cb, create_prepare_cb, 0U,
- param);
+ err = lll_prepare(is_abort_cb, abort_cb, create_prepare_cb, 0U, param);
File:subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c
Line:153
You may want to run clang-format on this change:
-static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll,
- uint16_t latency, uint8_t bn,
- uint16_t handle,
- struct node_rx_pdu *node_rx)
+static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll, uint16_t latency,
+ uint8_t bn, uint16_t handle, struct node_rx_pdu *node_rx)
File:subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c
Line:1404
You may want to run clang-format on this change:
- iso_meta->timestamp -= (latency * lll->iso_interval *
- PERIODIC_INT_UNIT_US);
+ iso_meta->timestamp -= (latency * lll->iso_interval * PERIODIC_INT_UNIT_US);
File:subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c
Line:1422
You may want to run clang-format on this change:
-#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
- (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && \
- defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
-#if defined(CONFIG_BT_CTLR_ADV_PERIODIC) && \
- defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
+ (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
+#if defined(CONFIG_BT_CTLR_ADV_PERIODIC) && defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
static void ticker_update_op_cb(uint32_t status, void *param);
#endif /* CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO */
static struct ticker_ext ll_adv_aux_ticker_ext[CONFIG_BT_CTLR_ADV_AUX_SET];
-#endif /* CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW ||
- * (CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#endif /* CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW || \
+ * (CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO) \
File:subsys/bluetooth/controller/ll_sw/ull_adv_aux.c
Line:85
You may want to run clang-format on this change:
-#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
- (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && \
- defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
+#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
+ (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
ret_cb = TICKER_STATUS_BUSY;
ret = ticker_start_ext(
-#else /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW &&
- * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#else /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW && \
+ * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO) \
*/
ret_cb = TICKER_STATUS_BUSY;
ret = ticker_start(
-#endif /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW &&
- * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#endif /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW && \
+ * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO) \
*/
- TICKER_INSTANCE_ID_CTLR, TICKER_USER_ID_THREAD,
- (TICKER_ID_ADV_AUX_BASE + aux_handle),
- ticks_anchor, 0U,
- HAL_TICKER_US_TO_TICKS(interval_us),
- HAL_TICKER_REMA
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c#L63
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c:63
-static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll,
- uint16_t latency, uint8_t bn,
- uint16_t handle,
- struct node_rx_pdu *node_rx);
+static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll, uint16_t latency,
+ uint8_t bn, uint16_t handle, struct node_rx_pdu *node_rx);
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c#L153
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c:153
- err = lll_prepare(is_abort_cb, abort_cb, create_prepare_cb, 0U,
- param);
+ err = lll_prepare(is_abort_cb, abort_cb, create_prepare_cb, 0U, param);
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c#L1404
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c:1404
-static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll,
- uint16_t latency, uint8_t bn,
- uint16_t handle,
- struct node_rx_pdu *node_rx)
+static void isr_rx_iso_data_invalid(const struct lll_sync_iso *const lll, uint16_t latency,
+ uint8_t bn, uint16_t handle, struct node_rx_pdu *node_rx)
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c#L1422
subsys/bluetooth/controller/ll_sw/nordic/lll/lll_sync_iso.c:1422
- iso_meta->timestamp -= (latency * lll->iso_interval *
- PERIODIC_INT_UNIT_US);
+ iso_meta->timestamp -= (latency * lll->iso_interval * PERIODIC_INT_UNIT_US);
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ll_sw/ull_adv_aux.c#L85
subsys/bluetooth/controller/ll_sw/ull_adv_aux.c:85
-#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
- (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && \
- defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
-#if defined(CONFIG_BT_CTLR_ADV_PERIODIC) && \
- defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
+ (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
+#if defined(CONFIG_BT_CTLR_ADV_PERIODIC) && defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
static void ticker_update_op_cb(uint32_t status, void *param);
#endif /* CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO */
static struct ticker_ext ll_adv_aux_ticker_ext[CONFIG_BT_CTLR_ADV_AUX_SET];
-#endif /* CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW ||
- * (CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#endif /* CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW || \
+ * (CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO) \
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ll_sw/ull_adv_aux.c#L2661
subsys/bluetooth/controller/ll_sw/ull_adv_aux.c:2661
-#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
- (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && \
- defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
+#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
+ (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
ret_cb = TICKER_STATUS_BUSY;
ret = ticker_start_ext(
-#else /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW &&
- * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#else /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW && \
+ * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO) \
*/
ret_cb = TICKER_STATUS_BUSY;
ret = ticker_start(
-#endif /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW &&
- * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+#endif /* !CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW && \
+ * !(CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO) \
*/
- TICKER_INSTANCE_ID_CTLR, TICKER_USER_ID_THREAD,
- (TICKER_ID_ADV_AUX_BASE + aux_handle),
- ticks_anchor, 0U,
- HAL_TICKER_US_TO_TICKS(interval_us),
- HAL_TICKER_REMAINDER(interval_us), TICKER_NULL_LAZY,
- (aux->ull.ticks_slot + ticks_slot_overhead),
- ticker_cb, aux,
- ull_ticker_status_give, (void *)&ret_cb
-#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
- (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && \
- defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
- ,
- &ll_adv_aux_ticker_ext[aux_handle]
-#endif /* CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW ||
- * (CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO)
+ TICKER_INSTANCE_ID_CTLR, TICKER_USER_ID_THREAD,
+ (TICKER_ID_ADV_AUX_BASE + aux_handle), ticks_anchor, 0U,
+ HAL_TICKER_US_TO_TICKS(interval_us), HAL_TICKER_REMAINDER(interval_us),
+ TICKER_NULL_LAZY, (aux->ull.ticks_slot + ticks_slot_overhead), ticker_cb, aux,
+ ull_ticker_status_give, (void *)&ret_cb
+#if defined(CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW) || \
+ (defined(CONFIG_BT_CTLR_ADV_PERIODIC) && defined(CONFIG_BT_TICKER_EXT_EXPIRE_INFO))
+ ,
+ &ll_adv_aux_ticker_ext[aux_handle]
+#endif /* CONFIG_BT_CTLR_ADV_AUX_SLOT_WINDOW || \
+ * (CONFIG_BT_CTLR_ADV_PERIODIC && CONFIG_BT_TICKER_EXT_EXPIRE_INFO) \
*/
- );
+ );
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ll_sw/ull_sync_iso.c#L614
subsys/bluetooth/controller/ll_sw/ull_sync_iso.c:614
- ctrl_spacing = PDU_BIS_US(sizeof(struct pdu_big_ctrl), lll->enc,
- lll->phy, PHY_FLAGS_S8);
+ ctrl_spacing =
+ PDU_BIS_US(sizeof(struct pdu_big_ctrl), lll->enc, lll->phy, PHY_FLAGS_S8);
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ticker/ticker.c#L988
subsys/bluetooth/controller/ticker/ticker.c:988
- (TICKER_HAS_SLOT_WINDOW(ticker) &&
- !ticker->ticks_slot &&
- ((acc_ticks_to_expire +
- ticker_next->ticks_slot) <=
+ (TICKER_HAS_SLOT_WINDOW(ticker) && !ticker->ticks_slot &&
+ ((acc_ticks_to_expire + ticker_next->ticks_slot) <=
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ticker/ticker.c#L2560
subsys/bluetooth/controller/ticker/ticker.c:2560
- if (((window_start_ticks + ticks_slot) <=
- ticks_slot_window) &&
- (window_end_ticks >= (ticks_start_offset +
- ticks_slot))) {
- if (!ticker_resched->ticks_slot ||
- ext_data->is_drift_in_window) {
+ if (((window_start_ticks + ticks_slot) <= ticks_slot_window) &&
+ (window_end_ticks >= (ticks_start_offset + ticks_slot))) {
+ if (!ticker_resched->ticks_slot || ext_data->is_drift_in_window) {
|
|
You may want to run clang-format on this change:
subsys/bluetooth/controller/ticker/ticker.c#L2627
subsys/bluetooth/controller/ticker/ticker.c:2627
- if (!ticker_resched->ticks_slot ||
- ext_data->is_drift_in_window) {
+ if (!ticker_resched->ticks_slot || ext_data->is_drift_in_window) {
if (!ticker_resched->ticks_slot ||
- (window_start_ticks <= (ticks_slot_window -
- ticks_slot))) {
+ (window_start_ticks <= (ticks_slot_window - ticks_slot))) {
/* Try at the end of the next node */
ticks_to_expire = window_start_ticks;
}
} else if (IS_ENABLED(CONFIG_BT_TICKER_EXT_SLOT_WINDOW_YIELD) &&
- (ticker_resched->ticks_periodic <
- ticker_next->ticks_periodic)) {
+ (ticker_resched->ticks_periodic < ticker_next->ticks_periodic)) {
/* Try to place it before the overlap and be
* rescheduled to its next periodic interval
* for collision resolution.
*/
if (ticks_start_offset > ticks_slot) {
- ticks_to_expire = ticks_start_offset -
- ticks_slot;
+ ticks_to_expire = ticks_start_offset - ticks_slot;
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
compliance.xml
|
3.11 KB |
|