Arch arm cortex m direct dynamic irqs #21516

ioannisg · 2019-12-19T11:24:20Z

DIrect Dynamic Interrupt Feature support for ARM Cortex-M

tests/arch/arm/arm_irq_advanced_features/src/arm_dynamic_direct_interrupts.c

zephyrbot · 2019-12-19T11:31:15Z

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

tests/arch/arm/arm_irq_advanced_features/src/arm_dynamic_direct_interrupts.c

arch/arm/core/irq_manage.c

include/arch/arm/irq.h

carlescufi · 2019-12-20T20:36:44Z

@ioannisg please rebase

ioannisg · 2019-12-22T23:16:12Z

@ioannisg please rebase

@carlescufi rebased :)

carlescufi · 2019-12-23T18:53:28Z

@ioannisg there seems to be an issue with shippable. Perhaps it just needs a rebase.

dbkinder

+1 for doc changes

andrewboie

No complaints other than a suspicion that the Kconfig isn't quite ideal

arch/arm/core/aarch32/cortex_m/Kconfig

ulfalizer · 2020-01-02T21:26:04Z

arch/arm/core/aarch32/cortex_m/Kconfig

+	help
+	  Enable installation of interrupt service routines for Direct
+	  interrupts at runtime.
+	  Note: this enables support for dynamic interrupts in the kernel.


Could flesh out this help text a bit maybe. Could explain what direct interrupts are (and maybe lowercase 'direct'), give some links, mention any Zephyr-specifics, etc. In the Linux kernel, checkpatch.pl warns if the help text is less than four lines, but maybe our version is old.

I see. So, I've changed 'Direct' to lowercase, thanks.

Well, the provided API (see in this PR) has all the documentation for direct dynamic interrupts. So I've just copied here a minor phrase briefly explaining direct interrupts.

In general the help-text of Kconfig symbols does not need to explain in detail the feature/functionality; we've got documentation for that. :)

ioannisg

@ulfalizer comments addressed, pls, take another look

ioannisg · 2020-01-07T09:26:00Z

@ulfalizer @andrewboie could you re-visit your reviews, here, so we could resolve this one?

andrewboie · 2020-01-08T01:22:28Z

Please change the Kconfig to have "depends on" and not "select". Users will need to enable both.

With this commit we add support for Dynamic Direct interrupts for the ARM Cortex-M architecture. For that we introduce a new, user-enabled, Kconfig symbol, DYNAMIC_DIRECT_INTERRUPTS. Signed-off-by: Ioannis Glaropoulos <[email protected]>

This commits implements the support for dynamic direct interrupts for the ARM Cortex-M architecture, and exposes the support to the user as an ARM-only API. Signed-off-by: Ioannis Glaropoulos <[email protected]>

Document that the Dynamic Direct interrupts feature is implemented and supported as an ARM-only API. Signed-off-by: Ioannis Glaropoulos <[email protected]>

Move the zero-latency IRQ test into the new arm_irq_advanced_features' test suite. Skip running the test for non Mainline Cortex-M. Signed-off-by: Ioannis Glaropoulos <[email protected]>

We add a test-suite for the newly introduced feature of ARM Dynamic Direct Interrupts. Signed-off-by: Ioannis Glaropoulos <[email protected]>

ioannisg · 2020-01-08T08:32:14Z

Please change the Kconfig to have "depends on" and not "select". Users will need to enable both.

That's alright then, @andrewboie , I' ve done that now, so using this feature requires both Kconfigs be set, thanks for looking at it.

ioannisg requested review from joerchan and carlescufi December 19, 2019 11:24

ioannisg added the Release Notes To be mentioned in the release notes label Dec 19, 2019

ioannisg added this to the v2.2.0 milestone Dec 19, 2019

carlescufi reviewed Dec 19, 2019

View reviewed changes

tests/arch/arm/arm_irq_advanced_features/src/arm_dynamic_direct_interrupts.c Outdated Show resolved Hide resolved

zephyrbot added area: ARM ARM (32-bit) Architecture area: API Changes to public APIs area: Tests Issues related to a particular existing or missing test labels Dec 19, 2019

joerchan reviewed Dec 19, 2019

View reviewed changes

tests/arch/arm/arm_irq_advanced_features/src/arm_dynamic_direct_interrupts.c Outdated Show resolved Hide resolved

ioannisg force-pushed the arch_arm_cortex_m_direct_dynamic_irqs branch 2 times, most recently from c66ec9e to 2545b32 Compare December 19, 2019 12:05

carlescufi reviewed Dec 19, 2019

View reviewed changes

arch/arm/core/irq_manage.c Outdated Show resolved Hide resolved

ioannisg force-pushed the arch_arm_cortex_m_direct_dynamic_irqs branch 2 times, most recently from 5d7185d to c1f1bba Compare December 19, 2019 13:37

ioannisg marked this pull request as ready for review December 19, 2019 13:37

ioannisg requested review from andrewboie, dbkinder, galak and MaureenHelm as code owners December 19, 2019 13:37

ioannisg requested review from joerchan and carlescufi December 19, 2019 13:37

ioannisg self-assigned this Dec 19, 2019

zephyrbot added the area: Documentation label Dec 19, 2019

carlescufi reviewed Dec 19, 2019

View reviewed changes

include/arch/arm/irq.h Outdated Show resolved Hide resolved

ioannisg requested a review from cvinayak December 19, 2019 15:08

andrewboie approved these changes Dec 19, 2019

View reviewed changes

ioannisg force-pushed the arch_arm_cortex_m_direct_dynamic_irqs branch 2 times, most recently from 3b84983 to c867075 Compare December 20, 2019 10:06

ioannisg requested a review from carlescufi December 20, 2019 10:08

joerchan approved these changes Dec 20, 2019

View reviewed changes

carlescufi approved these changes Dec 20, 2019

View reviewed changes

ioannisg force-pushed the arch_arm_cortex_m_direct_dynamic_irqs branch from bcd144f to c00f6d3 Compare December 22, 2019 23:00

dbkinder approved these changes Dec 23, 2019

View reviewed changes

ioannisg force-pushed the arch_arm_cortex_m_direct_dynamic_irqs branch from c00f6d3 to cd4ac87 Compare December 26, 2019 19:51

ioannisg closed this Dec 27, 2019

ioannisg reopened this Dec 27, 2019

ioannisg mentioned this pull request Jan 2, 2020

Support for direct dynamic IRQs in nRF devices #20387

Closed

ioannisg closed this Jan 2, 2020

ioannisg reopened this Jan 2, 2020

andrewboie reviewed Jan 2, 2020

View reviewed changes

arch/arm/core/aarch32/cortex_m/Kconfig Outdated Show resolved Hide resolved

andrewboie requested a review from ulfalizer January 2, 2020 21:13

ulfalizer reviewed Jan 2, 2020

View reviewed changes

ioannisg force-pushed the arch_arm_cortex_m_direct_dynamic_irqs branch from cd4ac87 to 413144f Compare January 3, 2020 09:19

ioannisg requested a review from ulfalizer January 3, 2020 09:20

ioannisg commented Jan 3, 2020

View reviewed changes

ioannisg added 5 commits January 8, 2020 09:31

arch: arm: cortex-m: implement support for dynamic direct interrupts

8904df4

This commits implements the support for dynamic direct interrupts for the ARM Cortex-M architecture, and exposes the support to the user as an ARM-only API. Signed-off-by: Ioannis Glaropoulos <[email protected]>

doc: list dynamic direct interrupts as ARM supported API

fcdf60a

Document that the Dynamic Direct interrupts feature is implemented and supported as an ARM-only API. Signed-off-by: Ioannis Glaropoulos <[email protected]>

tests: arch: arm: move ZLI test to arm_irq_advanced_features suite

39d9bb4

Move the zero-latency IRQ test into the new arm_irq_advanced_features' test suite. Skip running the test for non Mainline Cortex-M. Signed-off-by: Ioannis Glaropoulos <[email protected]>

tests: arch: arm: add test-suite for dynamic direct IRQs

2184cec

We add a test-suite for the newly introduced feature of ARM Dynamic Direct Interrupts. Signed-off-by: Ioannis Glaropoulos <[email protected]>

ioannisg force-pushed the arch_arm_cortex_m_direct_dynamic_irqs branch from 413144f to 2184cec Compare January 8, 2020 08:31

ioannisg mentioned this pull request Jan 8, 2020

RFC: list required / optional arch features and clarify policy #18273

Open

andrewboie merged commit 80992d0 into zephyrproject-rtos:master Jan 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arch arm cortex m direct dynamic irqs #21516

Arch arm cortex m direct dynamic irqs #21516

ioannisg commented Dec 19, 2019 •

edited

Loading

zephyrbot commented Dec 19, 2019 •

edited

Loading

carlescufi commented Dec 20, 2019

ioannisg commented Dec 22, 2019

carlescufi commented Dec 23, 2019

dbkinder left a comment

andrewboie left a comment

ulfalizer Jan 2, 2020 •

edited

Loading

ioannisg Jan 3, 2020

ioannisg left a comment

ioannisg commented Jan 7, 2020

andrewboie commented Jan 8, 2020

ioannisg commented Jan 8, 2020

Arch arm cortex m direct dynamic irqs #21516

Arch arm cortex m direct dynamic irqs #21516

Conversation

ioannisg commented Dec 19, 2019 • edited Loading

zephyrbot commented Dec 19, 2019 • edited Loading

carlescufi commented Dec 20, 2019

ioannisg commented Dec 22, 2019

carlescufi commented Dec 23, 2019

dbkinder left a comment

Choose a reason for hiding this comment

andrewboie left a comment

Choose a reason for hiding this comment

ulfalizer Jan 2, 2020 • edited Loading

Choose a reason for hiding this comment

ioannisg Jan 3, 2020

Choose a reason for hiding this comment

ioannisg left a comment

Choose a reason for hiding this comment

ioannisg commented Jan 7, 2020

andrewboie commented Jan 8, 2020

ioannisg commented Jan 8, 2020

ioannisg commented Dec 19, 2019 •

edited

Loading

zephyrbot commented Dec 19, 2019 •

edited

Loading

ulfalizer Jan 2, 2020 •

edited

Loading