shell: introduce shell_xxx_impl wrapper functions for output macros
#75340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrs-pst
force-pushed
the
pr_shell_shell_xxx_impl_wrapper
branch
from
82ac281
to
3aee3fa
Compare
|
Additional information
|
Refactor shell output macros to minimize caller overhead by eliminating direct `color` parameter passing: - Introduce wrapper functions: `shell_info_impl`, `shell_print_impl`, `shell_warn_impl`, `shell_error_impl`. - Replace `shell_fprintf` in macros with these new wrappers. - Update `shell_hexdump_line` to use the new wrappers, minimizing caller overhead. Signed-off-by: Pisit Sawangvonganan <[email protected]>
ndrs-pst
force-pushed
the
pr_shell_shell_xxx_impl_wrapper
branch
from
3aee3fa
to
8b338cd
Compare
jakub-uC
approved these changes
Jul 4, 2024
|
Ping @carlescufi for review. If this PR can be merged, I can leverage this wrapper in many places 😃. |
pdgendt
approved these changes
Jul 9, 2024
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Jul 28, 2024
Due to the introduction of `shell_xxx_impl` wrapper functions in PR zephyrproject-rtos#75340, we can minimize caller overhead by eliminating direct `color` parameter passing. This is achieved by using `shell_print_impl`, `shell_error_impl`, `shell_info_impl` and `shell_warn_impl` instead of `shell_fprintf`. Signed-off-by: Pisit Sawangvonganan <[email protected]>
carlescufi
pushed a commit
that referenced
this pull request
Jul 31, 2024
Due to the introduction of `shell_xxx_impl` wrapper functions in PR #75340, we can minimize caller overhead by eliminating direct `color` parameter passing. This is achieved by using `shell_print_impl`, `shell_error_impl`, `shell_info_impl` and `shell_warn_impl` instead of `shell_fprintf`. Signed-off-by: Pisit Sawangvonganan <[email protected]>
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Aug 16, 2024
Due to the introduction of `shell_xxx_impl` wrapper functions in PR zephyrproject-rtos#75340, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
Chenhongren
pushed a commit
to Chenhongren/zephyr
that referenced
this pull request
Aug 26, 2024
Due to the introduction of `shell_xxx_impl` wrapper functions in PR zephyrproject-rtos#75340, we can minimize caller overhead by eliminating direct `color` parameter passing. This is achieved by using `shell_print_impl`, `shell_error_impl`, `shell_info_impl` and `shell_warn_impl` instead of `shell_fprintf`. (cherry picked from commit 16386d7) Original-Signed-off-by: Pisit Sawangvonganan <[email protected]> GitOrigin-RevId: 16386d7 Change-Id: I1c97cadf3ca9301f487496041e03c57ed88de64c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5752451 Reviewed-by: Fabio Baltieri <[email protected]> Tested-by: Fabio Baltieri <[email protected]> Commit-Queue: Fabio Baltieri <[email protected]> Tested-by: ChromeOS Prod (Robot) <[email protected]>
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Sep 10, 2024
…intf` Due to the introduction of `shell_xxx_impl` wrapper functions in PR zephyrproject-rtos#75340 and rename to `shell_fprintf_xxx` in PR zephyrproject-rtos#77192 we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
carlescufi
pushed a commit
that referenced
this pull request
Sep 10, 2024
…intf` Due to the introduction of `shell_xxx_impl` wrapper functions in PR #75340 and rename to `shell_fprintf_xxx` in PR #77192 we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
nagelkl
pushed a commit
to nagelkl/zephyr
that referenced
this pull request
Sep 16, 2024
…intf` Due to the introduction of `shell_xxx_impl` wrapper functions in PR zephyrproject-rtos#75340 and rename to `shell_fprintf_xxx` in PR zephyrproject-rtos#77192 we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor shell output macros to minimize caller overhead by eliminating direct
colorparameter passing:shell_info_impl,shell_print_impl,shell_warn_impl,shell_error_impl.shell_fprintfin macros with these new wrappers.shell_hexdump_lineto use the new wrappers, minimizing caller overhead.