doc: update mac instructions #7537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
approved these changes
May 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #7537 +/- ##
=======================================
Coverage 55.25% 55.25%
=======================================
Files 468 468
Lines 51673 51673
Branches 9893 9893
=======================================
Hits 28554 28554
Misses 19206 19206
Partials 3913 3913Continue to review full report at Codecov.
|
dbkinder
suggested changes
May 15, 2018
| @@ -108,114 +108,21 @@ To build for the ARM-based Nordic nRF52 Development Kit: | |||
| Setting Up the Toolchain | |||
| ************************ | |||
|
|
|||
| Install tools needed for building the toolchain (if needed): | |||
| In case a toolchain is not available for the board you are using, you can build | |||
| a the toolchain from scratch using crosstool-NG. Follow the steps on the | |||
There was a problem hiding this comment.
change a the toolchain to a toolchain
| Install tools needed for building the toolchain (if needed): | ||
| In case a toolchain is not available for the board you are using, you can build | ||
| a the toolchain from scratch using crosstool-NG. Follow the steps on the | ||
| crosstool-NG website to prepare your `host |
There was a problem hiding this comment.
as written, only the word host would be clickable... better would be include prepare your too:
website to `prepare your host
<http://crosstool-ng.github.io/docs/os-setup/>`_
| :file:`${ZEPHYR_BASE}/scripts/cross_compiler/`. | ||
|
|
||
| Currently the following configurations are provided: | ||
| Follow the steps `here |
There was a problem hiding this comment.
Better would be:
Follow the `Zephyr SDK with Crosstool NG instructions
<https://github.com/zephyrproject-rtos/sdk-ng/blob/master/README.md>`_ to build ...
Use sdn-ng scripts to build toolchain instead of repeating them here. Fixes zephyrproject-rtos#6912 Signed-off-by: Anas Nashif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sdn-ng scripts to build toolchain instead of repeating them here.
Fixes #6912
Fixes #6897
Signed-off-by: Anas Nashif [email protected]