Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edma3 for s32z270dc2 board #78368

Merged

Conversation

haduongquang
Copy link
Contributor

This PR introduces NXP S32 EDMA3 driver for SoC NXP S32Z27 and enables its usage for board s32z270dc2

Tests:

tests\drivers\dma\chan_blen_transfer:
SUITE PASS - 100.00% [dma_m2m]: pass = 4, fail = 0, skip = 0, total = 4 duration = 8.063 seconds

tests\drivers\dma\chan_link_transfer:
SUITE PASS - 100.00% [dma_m2m_link]: pass = 3, fail = 0, skip = 0, total = 3 duration = 6.047 seconds

tests\drivers\dma\loop_transfer:
SUITE PASS - 100.00% [dma_m2m_loop]: pass = 3, fail = 0, skip = 0, total = 3 duration = 1.103 seconds

tests\drivers\dma\scatter_gather:
SUITE PASS - 100.00% [dma_m2m_sg]: pass = 1, fail = 0, skip = 0, total = 1 duration = 0.076 seconds

@zephyrbot
Copy link
Collaborator

zephyrbot commented Sep 13, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@c42b8ee zephyrproject-rtos/hal_nxp@4597b16 zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Sep 13, 2024
@decsny decsny requested review from EmilioCBen and removed request for decsny September 13, 2024 13:50
@haduongquang haduongquang force-pushed the support-edma3-for-s32z-2.0.0 branch 7 times, most recently from 6d05b95 to 8efc8f3 Compare September 17, 2024 07:58
@haduongquang
Copy link
Contributor Author

Added commit to Split tcdpool per device that can be used for multiple instances.

@haduongquang
Copy link
Contributor Author

@teburd @manuargue @Dat-NguyenDuy please help me take a look into this PR. All comments addressed. Thanks

manuargue
manuargue previously approved these changes Sep 28, 2024
Dat-NguyenDuy
Dat-NguyenDuy previously approved these changes Sep 30, 2024
@haduongquang
Copy link
Contributor Author

Hi @teburd, Could you please help me take a look into this PR?

@haduongquang
Copy link
Contributor Author

I rebased and fixed the conflict.

@manuargue manuargue added this to the v4.0.0 milestone Oct 9, 2024
Dat-NguyenDuy
Dat-NguyenDuy previously approved these changes Oct 9, 2024
dleach02
dleach02 previously approved these changes Oct 15, 2024
@dleach02
Copy link
Member

dleach02 commented Oct 15, 2024

@teburd I've add @manuargue (NXP S32 platform maintainer) as a co-assignee so we can move forward with this PR.

@manuargue
Copy link
Member

manuargue commented Oct 18, 2024

@haduongquang HAL pr merged, please rebase and update manifest to 4597b16cfedf5553cb155151e65eb994d5d0ef25

Copy link
Member

@manuargue manuargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking until #78314 is merged and update the manifest

Support multiple instances for dma.

Memset struct data and tcdpool on initialization is not necessary.
Therefore remove it.

Signed-off-by: Ha Duong Quang <[email protected]>
@haduongquang
Copy link
Contributor Author

blocking until #78314 is merged and update the manifest

I rebased and updated the manifest

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 18, 2024
Enable support EDMA for S32Z270.
Add eDMA3 instance 0, 1, 4 and 5 for S32Z270 devices.

Signed-off-by: Ha Duong Quang <[email protected]>
Enable dma boards/test for S32Z270.

The non-cacheable memory used for DMA tests (chan_blen_transfer and
loop_transfer) is split from the system SRAM.

Signed-off-by: Ha Duong Quang <[email protected]>
Copy link
Member

@manuargue manuargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dismiss #78368 (review), my mistake, first we need to merge this pr

@carlescufi carlescufi merged commit 08a4259 into zephyrproject-rtos:main Oct 18, 2024
31 checks passed
@manuargue manuargue deleted the support-edma3-for-s32z-2.0.0 branch October 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DMA Direct Memory Access manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP S32 NXP Semiconductors, S32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants