Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usb: shell: Remove use of ctx_shell #81395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Thalley
Copy link
Collaborator

@Thalley Thalley commented Nov 14, 2024

The ctx_shell was only used a single place and in a function that already has a sh that would be better to use.

The ctx_shell was only used a single place and in a function
that already has a `sh` that would be better to use.

Signed-off-by: Emil Gydesen <[email protected]>
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thalley why a draft? This looks like a trivial change.

@Thalley
Copy link
Collaborator Author

Thalley commented Nov 14, 2024

@Thalley why a draft? This looks like a trivial change.

I always keep PRs in draft until they reach their first CI pass :)

@Thalley Thalley marked this pull request as ready for review November 14, 2024 12:28
@zephyrbot zephyrbot added the area: USB Universal Serial Bus label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: USB Universal Serial Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants