[WIP] drivers: i2c: Add dts support for i2c slaves. #9943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mierunski
force-pushed
the
twis_dts_support
branch
from
1292c21
to
75bb87c
Compare
Codecov Report
@@ Coverage Diff @@
## master #9943 +/- ##
=======================================
Coverage 52.58% 52.58%
=======================================
Files 213 213
Lines 26148 26148
Branches 5636 5636
=======================================
Hits 13749 13749
Misses 10145 10145
Partials 2254 2254Continue to review full report at Codecov.
|
12 tasks
MaureenHelm
requested changes
Sep 21, 2018
drivers/i2c/slave/Kconfig.eeprom
Outdated
| hex "I2C Slave EEPROM 1 address" | ||
| depends on I2C_EEPROM_SLAVE_1 | ||
| default 0x56 | ||
| default n |
scripts/dts/extract/globals.py
Outdated
| for k, v in root['children']['aliases']['props'].items(): | ||
| print(k) | ||
| print(v) |
There was a problem hiding this comment.
These look like debug statements and should be removed
b0661
reviewed
Sep 21, 2018
dts/bindings/i2c/i2c-slave.yaml
Outdated
| # | ||
| --- | ||
| title: I2C Slave Base Structure | ||
| id: i2c-slave |
There was a problem hiding this comment.
Can this become i2c-device instead of i2c-slave?
Convention in e.g. PR #9876 is to call devices that are attached to a bus a [bus]-device. Adhering to this convention could help in the extraction of device tree properties.
There was a problem hiding this comment.
Removed this file and switched to using i2c-device
Adding i2c slave requires overlay with node definitions and proper aliases depending on driver implementation. Modified i2c_slave_api test to use information from dts. Signed-off-by: Mieszko Mierunski <[email protected]>
Mierunski
force-pushed
the
twis_dts_support
branch
from
75bb87c
to
de228ec
Compare
MaureenHelm
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding i2c slave requires overlay with node definitions and
proper aliases depending on driver implementation.
Modified i2c_slave_api test to use information from dts.
To fully complete this PR, i2c_virtual driver has to be also contained in dts, however I don't know if it should be put among other drivers or in some special place.
Fixes #9920