Event type flexibility #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, that's really cool! I'll look into it more thoroughly tomorrow, but looks like an easy merge :) |
zeppelin
force-pushed
the
element-modifier
branch
from
e6504b0
to
30ada00
Compare
…-click-outside into element-modifier * 'element-modifier' of https://github.com/crowjonah/ember-click-outside: update readme allow legacy mixin to specify eventType too change named param to eventType allow named param "event" add failing test update lockfile Release v1.2.0-beta.0
|
I'll investigate why tests are suddenly failing, then merge right after |
Yeah, I looked briefly at the master branch and it looks like some of the latest and greatest modifier stuff might preclude earlier versions of ember and/or node. I see you have the modifier manager polyfill, though, so I'm not sure what the culprit could be. It could also be that a parser/babel upgrade is needed! |
* master: update node for travis fix lint update more deps and node update dependencies Revert "bump node version, remove legacy ember scenarios" bump node version, remove legacy ember scenarios
|
I've merged the lastest from |
|
@crowjonah Released as Thanks for the GREAT contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app I work on is currently using a fork of the mixin that allows for flexibility in the event to which the listener is bound (and removed). This is especially handy when something like a modal or popup is overlapping a large amount of an interactive element (in our case a map, where clicking and dragging pans across it).
I've just picked up the modifier work here in anticipation of the deprecation of mixins (emberjs/rfcs#528), and extended the event flexibility to this implementation.
I think this may also solve #48, and relates to #49
Note: dependencies haven't changed, but I did need to regenerate the lockfile in order to get tests to pass in the current state of your branch.